Update package registration logic #49566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refines the package registration logic in the RecordPackages method, ensuring that registrations are uniquely identified by both package name and version while removing the code that updated package versions.
- Updated the registration lookup to require a matching version in addition to the package name
- Removed the branch that updated the package version, enforcing immutability of registered package versions
Comments suppressed due to low confidence (2)
test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs:284
- Ensure the comment fully reflects the new behavior that both package name and version are used to identify an existing registration, minimizing any potential confusion.
// Find existing registration for this package with the SAME VERSION
test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs:307
- Consider adding or updating unit tests to verify that registrations with the same package name but different versions are handled as distinct entries, given the removal of version updating logic.
}
MarcoRossignoli
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for recording package registrations in the
RecordPackagesmethod ofDotnetNewTestTemplatesTests.cs. The changes ensure that package registrations are uniquely identified by both name and version, and remove code for updating versions of existing registrations.Enhancements to package registration logic:
test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs: Updated the logic to find existing package registrations by matching bothNameandVersionproperties, ensuring that registrations are version-specific.test/dotnet-new.IntegrationTests/DotnetNewTestTemplatesTests.cs: Removed the code that updated the version of an existing registration, simplifying the method and enforcing immutability of package versions once registered.Closes #48607