Consume shared components from external URI in non-1xx feature band #49607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds logic to allow the SDK to download shared components from external URIs when building non-1xx feature bands or outside the VMR, since only the 1xx band produces those artifacts locally.
- Refactors the MSBuild condition on the
<ItemGroup>to includeVersionSDKMinor != '1'alongsideDotNetBuildFromVMR != 'true' - Updates the XML comment to explain the new behavior for non-1xx feature bands
Comments suppressed due to low confidence (1)
src/Layout/redist/targets/RestoreLayout.targets:313
- Consider adding or updating functional tests or MSBuild integration tests to verify that UrisToDownload items are correctly included when building non-1xx feature bands or outside the VMR. This will catch regressions if the condition logic changes.
<ItemGroup Condition="'$(DotNetBuildFromVMR)' != 'true' or '$(VersionSDKMinor)' != '1'">
ellahathaway
approved these changes
Jun 30, 2025
mmitche
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/dotnet#1109
For non-1xx feature bands, shared components like runtime and aspnetcore are not produced directly by the build. Only the 1xx feature band produces them. So in the non-1xx feature bands of the VMR, the sdk needs to be able to download those shared component artifacts from external URIs rather than expecting them to exist in a local directory feed.
This applies to Microsoft builds only since those are allowed to download external artifacts like this. The work to support this for source-only builds is tracked with dotnet/dotnet#1111.