Avoid ConcurrentDictionary allocation in DisposeObjectsBeforeLosingScope #50309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @stephentoub! This is a PR that has been reviewed by you the other day (I re-created PR submitted by mistake to the old repo). Also I would like to contribute the following PRs with analyzer fixes and performance improvements: #50397 Is it possible to get these PRs reviewed? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
DisposeObjectsBeforeLosingScopeanalyzer always allocates aConcurrentDictionary<K, V>when it's initialized. As it's used to avoid reporting duplicate diagnostics for the same location, it's only needed when there are rule violations in code.Suggested improvement
Defer dictionary allocation until it's actually needed in the case when rule violations are detected. This should avoid the allocation for successful builds.
Testing
All unit tests for this analyzer passed.