Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/10.0.1xx] Add SelectRuntimeIdentifierSpecificItems MSBuild task for filtering items by compatible RuntimeIdentifier #50875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 17, 2025
Merged

[release/10.0.1xx] Add SelectRuntimeIdentifierSpecificItems MSBuild task for filtering items by compatible RuntimeIdentifier #50875

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93cfd50
Initial plan
Copilot Sep 3, 2025
ce83b90
Implement SelectRuntimeIdentifierSpecificItems MSBuild task with tests
Copilot Sep 3, 2025
bf9dbae
Add UsingTask declaration for SelectRuntimeIdentifierSpecificItems in…
Copilot Sep 3, 2025
1e3659f
Remove #nullable disable and add proper nullable reference type annot…
Copilot Sep 3, 2025
0a44483
Simplify runtime compatibility check to use runtimeGraph.AreCompatibl…
Copilot Sep 3, 2025
f351342
Update nullable annotations for Required properties to use null! pattern
Copilot Sep 3, 2025
2b0d005
Address Yanni's formatting feedback
baronfel Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nullable annotations for Required properties to use null! pattern 
Co-authored-by: baronfel <[email protected]>
  • Loading branch information
@Copilot @baronfel
2 people authored and github-actions committed Sep 16, 2025
commit f351342b1ce21ba3f7fdbf1e5574490f332894a1
26 changes: 6 additions & 20 deletions src/Tasks/Microsoft.NET.Build.Tasks/SelectRuntimeIdentifierSpecificItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ public class SelectRuntimeIdentifierSpecificItems : TaskBase
/// The target runtime identifier to check compatibility against.
/// </summary>
[Required]
public string? TargetRuntimeIdentifier { get; set; }
public string TargetRuntimeIdentifier { get; set; } = null!;

/// <summary>
/// The list of candidate items to filter.
/// </summary>
[Required]
public ITaskItem[]? Items { get; set; }
public ITaskItem[] Items { get; set; } = null!;

/// <summary>
/// The name of the MSBuild metadata to check on each item. Defaults to "RuntimeIdentifier".
Expand All @@ -37,7 +37,7 @@ public class SelectRuntimeIdentifierSpecificItems : TaskBase
/// Path to the RuntimeIdentifierGraph file.
/// </summary>
[Required]
public string? RuntimeIdentifierGraphPath { get; set; }
public string RuntimeIdentifierGraphPath { get; set; } = null!;

/// <summary>
/// The filtered items that are compatible with the target runtime identifier.
Expand All @@ -47,29 +47,15 @@ public class SelectRuntimeIdentifierSpecificItems : TaskBase

protected override void ExecuteCore()
{
if (Items == null || Items.Length == 0)
if (Items.Length == 0)
{
SelectedItems = Array.Empty<ITaskItem>();
return;
}

string targetRid = TargetRuntimeIdentifier ?? string.Empty;
string ridGraphPath = RuntimeIdentifierGraphPath ?? string.Empty;
string ridMetadata = RuntimeIdentifierItemMetadata ?? "RuntimeIdentifier";

if (string.IsNullOrEmpty(targetRid))
{
Log.LogError("TargetRuntimeIdentifier is required but was not provided.");
return;
}

if (string.IsNullOrEmpty(ridGraphPath))
{
Log.LogError("RuntimeIdentifierGraphPath is required but was not provided.");
return;
}

RuntimeGraph runtimeGraph = new RuntimeGraphCache(this).GetRuntimeGraph(ridGraphPath);
RuntimeGraph runtimeGraph = new RuntimeGraphCache(this).GetRuntimeGraph(RuntimeIdentifierGraphPath);

var selectedItems = new List<ITaskItem>();

Expand All @@ -84,7 +70,7 @@ protected override void ExecuteCore()
}

// Check if the item's runtime identifier is compatible with the target runtime identifier
if (runtimeGraph.AreCompatible(targetRid, itemRuntimeIdentifier))
if (runtimeGraph.AreCompatible(TargetRuntimeIdentifier, itemRuntimeIdentifier))
{
selectedItems.Add(item);
}
Expand Down