Improve build task tests #51192
Open
Improve build task tests #51192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ec98c3f to
ec6c62f
Compare
This was referenced Nov 12, 2025
Open
Copilot finished reviewing on behalf of
jjonescz
November 12, 2025 18:33
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Roslyn build task tests by adding target framework verification and expanding test coverage. The changes follow up on previous work to ensure that the correct compiler (either .NET Core or .NET Framework) is being used during builds.
Key changes:
- Added verification that the compiler used matches the expected target framework (.NET Core vs .NET Framework)
- Extended test coverage to validate both framework compiler and core compiler scenarios when using toolset packages
- Fixed a spelling error in a variable name
Member
Author
|
@333fred @RikkiGibson for reviews of a test-only improvement, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on dotnet/roslyn#80631 and #51612 (comment)