Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Hot Reload] Do not refresh browser until changes are applied #51210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

[Hot Reload] Do not refresh browser until changes are applied #51210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/BuiltInTools/HotReloadClient/Web/AbstractBrowserRefreshServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,14 +299,7 @@ public ValueTask RefreshBrowserAsync(CancellationToken cancellationToken)
public ValueTask ReportCompilationErrorsInBrowserAsync(ImmutableArray<string> compilationErrors, CancellationToken cancellationToken)
{
logger.Log(LogEvents.UpdatingDiagnostics);
if (compilationErrors.IsEmpty)
{
return SendJsonMessageAsync(new AspNetCoreHotReloadApplied(), cancellationToken);
}
else
{
return SendJsonMessageAsync(new HotReloadDiagnostics { Diagnostics = compilationErrors }, cancellationToken);
}
return SendJsonMessageAsync(new HotReloadDiagnostics { Diagnostics = compilationErrors }, cancellationToken);
}

public async ValueTask UpdateStaticAssetsAsync(IEnumerable<string> relativeUrls, CancellationToken cancellationToken)
Expand Down
17 changes: 17 additions & 0 deletions test/dotnet-watch.Tests/Browser/BrowserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,13 @@ await App.WaitUntilOutputContains("""
🧪 Received: Reload
""");

// no other browser message sent:
Assert.Equal(2, App.Process.Output.Count(line => line.Contains("🧪")));

await App.WaitForOutputLineContaining(MessageDescriptor.WaitingForChanges);

App.Process.ClearOutput();

// another rude edit:
UpdateSourceFile(homePagePath, src => src.Replace("public virtual int F() => 1;", "/* member placeholder */"));

Expand All @@ -98,13 +103,25 @@ await App.WaitUntilOutputContains("""
🧪 Received: Reload
""");

// no other browser message sent:
Assert.Equal(2, App.Process.Output.Count(line => line.Contains("🧪")));

App.Process.ClearOutput();

// valid edit:
UpdateSourceFile(homePagePath, src => src.Replace("/* member placeholder */", "public int F() => 1;"));

await App.WaitForOutputLineContaining(MessageDescriptor.HotReloadSucceeded);

await App.WaitUntilOutputContains($$"""
🧪 Received: {"type":"HotReloadDiagnosticsv1","diagnostics":[]}
""");

await App.WaitUntilOutputContains($$"""
🧪 Received: {"type":"AspNetCoreHotReloadApplied"}
""");

// no other browser message sent:
Assert.Equal(2, App.Process.Output.Count(line => line.Contains("🧪")));
}
}
Loading