You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will suppress the CodeQL violations that are showing up for the azure-activedirectory-identitymodel-extensions-for-dotnet repo. That team has given the ok that these are safe.
Has the identity model team given indication that they will address AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#3297? If not it feels wrong to suppress all codeql indefinitely. Can you open a tracking issue to remove this once they implement the appropriate suppressions?
If not it feels wrong to suppress all codeql indefinitely.
What is the alternative then?
We push relentlessly on the identity model team to add the appropriate suppressions. If they won't, perhaps we could open a PR. Maybe aspnet could be of help here if they have a relationship with them - cc @wtgodbe.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will suppress the CodeQL violations that are showing up for the
azure-activedirectory-identitymodel-extensions-for-dotnetrepo. That team has given the ok that these are safe.Related: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#3297