This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Update developer guide #579
Merged
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix instructions for installing local builds
JunTaoLuo
commented
Jul 14, 2020
| done | ||
|
|
||
| scriptroot="$( cd -P "$( dirname "$source" )" && pwd )" | ||
| "$scriptroot/eng/common/build.sh" --pack --build --restore $@ |
There was a problem hiding this comment.
It's odd that --pack is specified in the default build.sh, we don't do this elsewhere. Is there a reason for this in this repo?
There was a problem hiding this comment.
not sure, but we'd probably need to update the azure-pipelines yaml to add -pack if we remove it.
There was a problem hiding this comment.
azure-pipelines uses eng/common/cibuild.sh which passes --pack so it's not necessary to update anything. I took a look and it seems nothing else in the repo references or uses build.sh directly.
There was a problem hiding this comment.
Oh, you already removed pack... 😄
jkotalik
approved these changes
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #540