This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Refactore pipeline #811
Merged
Refactore pipeline #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sirh3e can you please combine all of your changes into a single PR instead of multiple PRs? Will be much easier for use to review. |
|
@jkotalik sure but pls give one more day 😀 |
|
@jkotalik are you sure it'll be easier? These are all non functional changes... |
|
Yeah I guess you are right. |
jkotalik
reviewed
Nov 23, 2020
| { | ||
| var method = pipeline.GetType().GetMethod("Register")!.MakeGenericMethod(type); | ||
| for (var i = 0; i < delegates.Count; i++) | ||
| foreach (var @delegate in delegates) |
There was a problem hiding this comment.
Personally not a fan of using @ variables.
There was a problem hiding this comment.
Delegate is much cleaner then del. Del could mean to much
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.