[release/9.0] Update Windows.Compatibility external packages. #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting to pick up version from dotnet/runtime#112139 |
|
We should raise the risk level on this - it's updating the major version of a dependency - something we typically do not do in servicing.
@Tanya-Solyanik you don't need to wait on anything. That version should flow automatically, just like other runtime packages. |
Tanya-Solyanik
commented
Mar 6, 2025
HongGit
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4884
Description:
An internal partner reported that Microsoft.Windows.Compatibility NuGet v8.0.12 package carries 3 assemblies(System.Data.SqlClient.dll, System.Diagnostics.EventLog.Messages.dll, and System.ServiceModel.dll) that do not have symbols on the Microsoft symbol server. The issue is not blocking for the partner, but we want to take this opportunity to update these packages to the newer, supported versions of external packages.
Fix:
System.Data.SqlClient.dll – updated to a newer compatibility package that has symbols
System.ServiceModel.dll - updated to a newer compatible package that is in support because it ships with the PowerShell. This package does not have symbols. The only WCF package that has symbols is V8 and introduces breaking changes.
System.Diagnostics.EventLog.Messages.dll – pdbs had been already added [release/9.0-staging] Include PDB for all TfmRuntimeSpecificPackageFile by github-actions[bot] · Pull Request #112139 · dotnet/runtime
Followup bugs
Symbol package questions · Issue dotnet/runtime#15457 · dotnet/arcade
What is the expected workflow for Symbols Validation of official releases? · Issue dotnet/arcade#15537 · dotnet/runtime
Customer Impact:
Windows partner has to store pdbs locally to be accessible for the duration of windows support term, which is longer that the .NET8’s. To achieve this goal, they are down loading pdbs from the symbol server, their script breaks on our package. They can’t upgrade to NET10, but can reverence the newer versions of these packages directly in their project.
Testing:
built the windows compatibility pack and verified that the right package versions are referenced.
Risk:
Low