Intermittent exception when creating a ListViewGroupAccessibleObject #10934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babced7 to
af5f665
Compare
…xample when the corresponding control is not displayed or not parented, thus changing nullability on this property. We were already guarding against accessing objects for "invisiable" groups in the parent ListViewAccessibleObject when enumerating children. We should not attempt to create accessible object for unparented ListView groups, for example when a group is removed from the control. This fix is based on this call stack: System.InvalidOperationException: ListView at System.Windows.Forms.ListViewGroup.ListViewGroupAccessibleObject..ctor(ListViewGroup owningGroup, Boolean owningGroupIsDefault) at System.Windows.Forms.ListViewGroup.get_AccessibilityObject() at System.Windows.Forms.ListView.OnGotFocus(EventArgs e) This is a follow up on dotnet#10910 (comment) Related to dotnet#4019
af5f665 to
b3ac40c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10934 +/- ##
===================================================
+ Coverage 62.72868% 62.74055% +0.01187%
===================================================
Files 1561 1562 +1
Lines 159997 159997
Branches 14918 14918
===================================================
+ Hits 100364 100383 +19
+ Misses 58857 58839 -18
+ Partials 776 775 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JeremyKuhne
requested changes
May 1, 2025
| return _accessibilityObject; | ||
| } | ||
|
|
||
| // Get ListView from the group item as a workaround for https://github.com/dotnet/winforms/issues/4019 |
There was a problem hiding this comment.
Can we explain this in addition to having the link?
Tanya-Solyanik
commented
May 1, 2025
src/System.Windows.Forms/System/Windows/Forms/Controls/ListView/ListViewGroup.cs
Outdated
Show resolved
Hide resolved
…w/ListViewGroup.cs
JeremyKuhne
approved these changes
May 1, 2025
|
test failure is a duplicate of #13291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is based on this call stack, I'm eliminating the top frame by creating this Accessibility object only when the parent control is available.
This is a follow up on #10910 (comment)
Related to #4019
I couldn't reproduce the issue, but the call stack is clear enough to understand the problem. There are situations when AccessibilityObject is not available, for example when the corresponding control is not displayed or not parented, thus changing nullability on this property. We were already guarding against accessing objects for "invisible" groups in the parent ListViewAccessibleObject when enumerating children.
We should not attempt to create accessible object for unparented ListView groups, for example when a group is removed from the control.
Microsoft Reviewers: Open in CodeFlow