Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add unit tests for DataSourceDescriptorCollection #12432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2024
Merged

Add unit tests for DataSourceDescriptorCollection #12432

merged 2 commits into from
Nov 7, 2024

Conversation

Nora-Zhou01
Copy link
Contributor

@Nora-Zhou01 Nora-Zhou01 commented Nov 6, 2024 •
edited
Loading

Related #10773

Proposed changes

  • Add unit test DataSourceDescriptorCollectionTests.cs for public properties and method of the DataSourceDescriptorCollection
  • Enable nullability in DataSourceDescriptorCollectionTests.cs

@Nora-Zhou01 Nora-Zhou01 requested a review from a team as a code owner November 6, 2024 07:28
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.03047%. Comparing base (e4085eb) to head (701e419).
Report is 306 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##                main      #12432          +/-   ##
====================================================
+ Coverage   75.01536%   97.03047%   +22.01510%     
====================================================
  Files           3047        1160        -1887     
  Lines         631584      351739      -279845     
  Branches       46764        5289       -41475     
====================================================
- Hits          473785      341294      -132491     
+ Misses        154434        9695      -144739     
+ Partials        3365         750        -2615
Flag Coverage Δ
Debug 97.03047% <95.23810%> (+22.01510%) ⬆️
integration ?
production ?
test 97.03047% <95.23810%> (+0.01399%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardobossan
ricardobossan reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small suggestion, LGTM.

@lonitra lonitra merged commit 9b0afc4 into dotnet:main Nov 7, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 7, 2024
@LeafShi1 LeafShi1 mentioned this pull request Nov 29, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
@Nora-Zhou01 Nora-Zhou01 deleted the Add-unit-tests-for-DataSourceDescriptorCollection branch January 16, 2025 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardobossan ricardobossan ricardobossan left review comments

@lonitra lonitra lonitra approved these changes

@LeafShi1 LeafShi1 Awaiting requested review from LeafShi1

@Epica3055 Epica3055 Awaiting requested review from Epica3055

Assignees

@Nora-Zhou01 Nora-Zhou01

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@Nora-Zhou01 @lonitra @ricardobossan