Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix 13077 Add missed events to ToolStripDesigner #13093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2025
Merged

Fix 13077 Add missed events to ToolStripDesigner #13093

merged 5 commits into from
Apr 3, 2025

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Mar 7, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #13077

Proposed changes

  • Update the ToolStripDesigner following by VS repo

Customer Impact

  • The "Type Here" item can be show in MenuStrip control and ToolStrip control in DemoConsole application

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

AfterChange

Test methodology

  • Manually

Test environment(s)

  • .net 10.0.0-preview.3.25154.11
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner March 7, 2025 09:52
@LeafShi1 LeafShi1 force-pushed the Issue_13077_Fix_Update_ToolStripDesigner branch from 058748a to 5b7a4f5 Compare March 10, 2025 01:18
@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Mar 10, 2025
Copilot
Copilot AI reviewed Mar 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request updates the ToolStripDesigner to add missing event-handling and improve event subscription and disposal logic, addressing issue #13077.

  • Added missing UndoEngine field and its event subscriptions.
  • Updated and refactored event hook-ups and unsubscriptions for the overflow drop-down and related components.
  • Cleaned up array initializations and simplified property implementations.

Reviewed Changes

File Description
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripDesigner.cs Updates to event subscription, disposal routines, and minor code cleanups to match the VS repository changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripDesigner.cs:996

  • [nitpick] Consider clarifying this comment to explain what 'DummyItem' refers to, for improved readability.
// We are DummyItem to the ToolStrip.

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.32143% with 59 lines in your changes missing coverage. Please review.

Project coverage is 61.54719%. Comparing base (eaaf38c) to head (e1e36d8).
Report is 143 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #13093         +/-   ##
===================================================
+ Coverage   61.28341%   61.54719%   +0.26377%     
===================================================
  Files           1541        1549          +8     
  Lines         158281      158662        +381     
  Branches       14743       14767         +24     
===================================================
+ Hits           97000       97652        +652     
+ Misses         60584       60307        -277     
- Partials         697         703          +6
Flag Coverage Δ
Debug 61.54719% <47.32143%> (-13.74488%) ⬇️
integration 10.71892% <0.00000%> (-8.19232%) ⬇️
production 39.50854% <47.32143%> (-35.78353%) ⬇️
test 95.67585% <ø> (∅)
unit 36.95375% <47.32143%> (-37.42562%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 11, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Mar 12, 2025
Tanya-Solyanik
Tanya-Solyanik reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 31, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Apr 2, 2025
Tanya-Solyanik
Tanya-Solyanik approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Apr 3, 2025
@Tanya-Solyanik Tanya-Solyanik merged commit bfcfed9 into dotnet:main Apr 3, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 3, 2025
@MelonWang1 MelonWang1 mentioned this pull request Apr 10, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

Copilot code review Copilot Copilot left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees

@LeafShi1 LeafShi1

Labels
None yet
Projects
None yet
Milestone
10.0 Preview4
Development

Successfully merging this pull request may close these issues.

Missed the "Type Here" item for the MenuStrip control in the DemoConsole application
3 participants
@LeafShi1 @Tanya-Solyanik @Epica3055