[release/9.0] fix #13305 Baseline SnapLines do not appear in DesignSurface #13349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #13349 +/- ##
=====================================================
+ Coverage 74.83837% 74.86194% +0.02357%
=====================================================
Files 3022 3022
Lines 630464 630506 +42
Branches 46801 46801
=====================================================
+ Hits 471829 472009 +180
+ Misses 155246 155114 -132
+ Partials 3389 3383 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Tanya-Solyanik
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13324 to release/9.0
The cause of this issue
This issue is caused by PR10279
These are two of all changes make in PR10279
BehaviorService,DragAssistanceManageruseSnapLinesto add some effects during design time.ControlDesignerhas a virtual propertySnapLines, but most designers override the property, in other words, most designers have customizedSnapLinesCode flow before PR10279
when
BehaviorServiceorDragAssistanceManageraccessesSnapLines, customizedSnapLineswere returned.Code flow after PR10279
ControlDesigner.cs
when
BehaviorServiceorDragAssistanceManageraccessesSnapLinesInternal, customizedSnapLineswere skipped.Proposed changes
SnapLinesScreenshots
Before
After
Test methodology