[release/8.0] InvalidOperationException when closing a dialog with focused DataGridView control #13350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntCell when changing or releasing DataSource (dotnet#13320) Fixes dotnet#13304 Root cause Regression introduced in PR dotnet#4637 When closing the dialog in edit mode, DataSource is set to null, and then CurrentCell = null is set. Then unnecessary method EndEdit of the SetCurrentCellAddressCore is called. Proposed changes Add _isReleasingDataSource in DataGridView and set it to null in property DataSource before setting CurrentCell = null to prevent the EndEdit method of the SetCurrentCellAddressCore from being called Customer Impact When the DataGridView is in editing mode, its dialog box can be closed normally Regression? Yes Risk Minimal
…sposed" (dotnet#13362) * Removing tag OperationInReleasingDataSource * Add judgment IsHandleCreated to before defining currentCell in function SetCurrentCellAddressCore
fdf2875 to
209b149
Compare
Tanya-Solyanik
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13320 to release/8.0
Fixes #13304
Proposed changes
EndEdittriggers theCurrentCellsetting logic, because the DGV's handle has been destroyed at this time, we are re-creating it and then re-enter logic that sets up the current cell causing an exception to be thrown. CheckingisHandleCreatedbefore callingEndEditcan avoid executing related logic when the control has been destroyed, thereby preventing exceptions from occurring.Customer Impact
Regression?
IndexOutOfRangeExceptionwhenever its datasource is disposed (servicing) #4637Testing
Risk
Microsoft Reviewers: Open in CodeFlow