[release/9.0] Fix Color value in PageSettings #13389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inadvertently flipped when changing to CsWin32. Fixes #13367
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #13389 +/- ##
======================================================
+ Coverage 44.90473% 74.84139% +29.93666%
======================================================
Files 1956 3022 +1066
Lines 284391 630476 +346085
Branches 41754 46802 +5048
======================================================
+ Hits 127705 471857 +344152
- Misses 149047 155236 +6189
+ Partials 7639 3383 -4256
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Tanya-Solyanik
approved these changes
Apr 29, 2025
danmoseley
reviewed
Apr 29, 2025
| public void Print_DefaultPrintController_Success() | ||
| { | ||
| if (!CanPrintToPdf()) | ||
| if (!Helpers.TryGetPdfPrinterName(out string? printerName)) | ||
| { | ||
| return; |
There was a problem hiding this comment.
this would be a bug if CanPrintToPdf is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13385 to release/9.0
/cc @JeremyKuhne
Customer Impact
Reading
PageSettings.Colorgives the wrong value, there is no workaround.Testing
Regression unit test.
Risk
Low, this was a manual mistake in converting to source generated interop.
Microsoft Reviewers: Open in CodeFlow