Allow IDataObjectAsyncCapability#13431
Merged
Merged
Conversation
Chromium based apps don't support file drop without using IDataObjectAsyncCapability. This includes the new Outlook. To support this we'll look for this interface in our current code paths and utilize it. This makes the async operation sync, which works, but isn't ideal. Chromium will pop a dialog that will leave WinForms modal as well until it is responded to. If this behavior creates an issue it can be disabled with the appcontext switch: "Windows.DragDrop.DisableSyncOverAsync" In order to truly support async we're also introducing a new interface to allow calling back off of the UI thread. This will be shipped as experimental for .NET 10 as there is a small risk we'll want to change the API based on real-world feedback. See dotnet#13422.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13431 +/- ##
===================================================
+ Coverage 62.72993% 62.74328% +0.01334%
===================================================
Files 1562 1562
Lines 159997 159998 +1
Branches 14918 14918
===================================================
+ Hits 100366 100388 +22
+ Misses 58856 58833 -23
- Partials 775 777 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
KlausLoeffelmann
left a comment
There was a problem hiding this comment.
Looks principally good to me.
I just had 2 questions.
But we should definitely get it over the finishline this week, so we have more time to test it.
This was referenced May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium based apps don't support file drop without using
IDataObjectAsyncCapability. This includes the new Outlook.To support this, we'll look for this interface in our current code paths and utilize it. This makes the async operation sync, which works, but isn't ideal. Chromium will pop a dialog that will leave WinForms modal as well until it is responded to.
If this behavior creates an issue, it can be disabled with the AppContext switch: "Windows.DragDrop.DisableSyncOverAsync"
In order to truly support async we're also introducing a new interface to allow calling back off of the UI thread. This will be shipped as experimental for .NET 10 as there is a small risk we'll want to change the API based on real-world feedback. See #13422.
Microsoft Reviewers: Open in CodeFlow