Unify namespaces and class names under DemoConsole #13433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related dotnet#13388 ## Proposed changes - Unifies `DesignSurfaceExt` and `DemoConsole` namespaces under the latter. - Renames class names where appropriate to reflect the shared project identity, in preparation for relocating all files into the `DemoConsole` folder in a follow-up PR. ## Customer Impact - None or succinct description ## Regression? - No ## Risk - Minimal ## Test environment(s) - 10.0.100-preview.3.25201.16
There was a problem hiding this comment.
Pull Request Overview
This pull request unifies the namespaces and class names under the DemoConsole identity to prepare for relocating files into the DemoConsole folder.
- Changed namespace from DesignSurfaceExt to DemoConsole throughout integration tests
- Renamed several classes and interfaces (e.g., UndoEngineExt → UndoEngineExtended, IDesignSurfaceExt → IDesignSurfaceExtended) for consistency
- Updated usage in MainForm and global usings to reflect the unified naming
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/integration/DesignSurface/DesignSurfaceExt/UndoEngineExt.cs | Updated namespace and renamed class from UndoEngineExt to UndoEngineExtended |
| src/test/integration/DesignSurface/DesignSurfaceExt/TabOrderHooker.cs | Updated namespace from DesignSurfaceExt to DemoConsole |
| src/test/integration/DesignSurface/DesignSurfaceExt/PropertyGridExt.cs | Updated namespace and renamed class from PropertyGridExt to PropertyGridExtended |
| src/test/integration/DesignSurface/DesignSurfaceExt/NameCreationServiceImp.cs | Updated namespace and renamed class from NameCreationServiceImp to NameCreationService |
| src/test/integration/DesignSurface/DesignSurfaceExt/IDesignSurfaceExt.cs | Updated namespace and renamed interface from IDesignSurfaceExt to IDesignSurfaceExtended |
| src/test/integration/DesignSurface/DesignSurfaceExt/DesignerSerializationServiceImpl.cs | Updated namespace and renamed class from DesignerSerializationServiceImpl to DesignerSerializationService |
| src/test/integration/DesignSurface/DesignSurfaceExt/DesignerOptionServiceExt.cs | Updated namespace from DesignSurfaceExt to DemoConsole |
| src/test/integration/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.cs | Updated namespace and renamed class from DesignSurfaceExt to DesignSurfaceExtended; updated field types accordingly |
| src/test/integration/DesignSurface/DemoConsole/MainForm.cs | Updated variable types from IDesignSurfaceExt to IDesignSurfaceExtended and usage of DesignSurfaceExtended |
| src/test/integration/DesignSurface/DemoConsole/GlobalUsings.cs | Updated global using from DesignSurfaceExt to DemoConsole |
Files not reviewed (1)
- src/test/integration/DesignSurface/DemoConsole/MainForm.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
src/test/integration/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.cs:8
- The constant value still uses 'DesignSurfaceExt' even though the class and namespace have been renamed to 'DemoConsole' and 'DesignSurfaceExtended'. Consider updating the constant to reflect the new naming for consistency.
private const string Name = "DesignSurfaceExt";
Tanya-Solyanik
approved these changes
May 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13433 +/- ##
===================================================
+ Coverage 76.59808% 76.60183% +0.00375%
===================================================
Files 3230 3230
Lines 639097 639097
Branches 47289 47289
===================================================
+ Hits 489536 489560 +24
+ Misses 145997 145964 -33
- Partials 3564 3573 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13388
Proposed changes
DesignSurfaceExtandDemoConsolenamespaces under the latter.DemoConsolefolder in a follow-up PR.Customer Impact
Regression?
Risk
Test environment(s)
Microsoft Reviewers: Open in CodeFlow