do not dispose stream owned by image #3404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3404 +/- ##
====================================================
- Coverage 65.14931% 34.19821% -30.95110%
====================================================
Files 1328 890 -438
Lines 489778 253832 -235946
Branches 40042 36793 -3249
====================================================
- Hits 319087 86806 -232281
+ Misses 165265 162258 -3007
+ Partials 5426 4768 -658
|
RussKie
approved these changes
Jun 9, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3309
Proposed changes
Loading an image from a stream passes ownership, do not dispose the stream
Customer Impact
Using ImageEditor or ImageListImageEditor through a property grid or designer was producing partially defunct images whose underlying stream was disposed, depending on the operation performed on the image this could load to errors.
Regression?
Yes
Risk
unlikely to have any risk, this restores behavior from before the regression
Before
Image loaded from ImageEditor or ImageListImageEditor could throw exceptions on various operations
After
Image loaded from ImageEditor or ImageListImageEditor should operate normally
Test methodology
Ensure unit tests perform an operation accessing the underlying stream.
Microsoft Reviewers: Open in CodeFlow