Add dependencies required by windowsdesktop #8909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks dotnet/windowsdesktop#3516 Microsoft.Windows.Compatibility is being migrated from runtime to windowsdesktop and depends on packages from dotnet/runtime. As there's already a subscription from runtime -> winforms, a new one can't be added directly between runtime -> windowsdesktop as that would cause coherency issues. Instead, we need to flow the dependencies through winforms and wpf.
ViktorHofer
added a commit
to ViktorHofer/runtime
that referenced
this pull request
Mar 28, 2023
dotnet/winforms#8909 moves the M.W.C package into windowsdesktop. Deleting the source from runtime and the package versions that aren't used anymore.
This was referenced Mar 28, 2023
mmitche
approved these changes
Mar 28, 2023
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Mar 28, 2023
dotnet/winforms#8909 moves the M.W.C package into windowsdesktop. Deleting the source from runtime and the package versions that aren't used anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/windowsdesktop#3516
Unblocks dotnet/wpf#7681
Microsoft.Windows.Compatibility is being migrated from runtime to windowsdesktop and depends on packages from dotnet/runtime. As there's already a subscription from
runtime -> winforms, a new one can't be added directly betweenruntime -> windowsdesktopas that would cause coherency issues. Instead, we need to flow the dependencies through winforms and wpf.The
git diffis confusing. I just added the new dependencies at the end of the product dependencies section and removed the ones that already existed from above so that all the ones that are required by windowsdesktop are grouped together.Note that I also removed the
Microsoft.Windows.Compatiblitydependency as that package is now produced in a higher layer (not runtime but windowsdesktop) so winforms can't depend on a live version of it. The package is only required for a test library so it felt safe to remove the live dependency and downgrade to last stable version.Microsoft Reviewers: Open in CodeFlow