-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace resource constants with properties in PresentationBuildTasks #7000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dipeshmsft
merged 3 commits into
dotnet:main
from
ThomasGoulet73:replace-resource-constants-with-properties-presentationbuildtasks
Oct 26, 2022
Merged
Replace resource constants with properties in PresentationBuildTasks #7000
dipeshmsft
merged 3 commits into
dotnet:main
from
ThomasGoulet73:replace-resource-constants-with-properties-presentationbuildtasks
Oct 26, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
Awesome! |
/azp run |
No pipelines are associated with this pull request. |
…ource-constants-with-properties-presentationbuildtasks
/azp run |
No pipelines are associated with this pull request. |
…resentationbuildtasks
Thank you @dipeshmsft |
singhashish-wpf
pushed a commit
that referenced
this pull request
Nov 1, 2022
…#7000) Contributes to #1 Co-authored-by: Dipesh Kumar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1
Description
Replace the use of resource constants with properties in PresentationBuildTasks. This follows the standard of other .Net projects, like dotnet/runtime.
Customer Impact
None.
Regression
No.
Testing
Local build + CI.
Risk
None.
Microsoft Reviewers: Open in CodeFlow