Overload ReassignProxyRequest to also accept a route update #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MihaZupan
reviewed
Jun 13, 2022
There was a problem hiding this comment.
Thanks @ethankrein!
Could you please also add a test for the new overload (similar to the existing one)?
Co-authored-by: Miha Zupan <[email protected]>
Fixing a spelling error
Is it okay that I extended that test to include the overload as well? |
MihaZupan
approved these changes
Jun 14, 2022
|
@MihaZupan - are you going to merge before you go on vacation? |
|
I want Chris to take a look at it first if this is the exact API he had in mind, but this is good to merge otherwise. |
Tratcher
approved these changes
Jun 15, 2022
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an overload for ReassignProxyRequest that assigns both route and cluster when reassigning a proxy request.
See discussions in #1749 and #1752 for more info.