Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update queue get/create/update logic in HttpSysDelegator.AddOrUpdateRules to avoid GC timing bug #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged

Update queue get/create/update logic in HttpSysDelegator.AddOrUpdateRules to avoid GC timing bug #2487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update queue get/create/update logic in HttpSysDelegator.AddOrUpdateR… 
…ules to avoid GC timing bug
  • Loading branch information
@NGloreous
NGloreous committed May 3, 2024
commit ef11b4573e59f0396c7bdcca7825a62dd3e6f6f7
54 changes: 19 additions & 35 deletions src/ReverseProxy/Delegation/HttpSysDelegator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,48 +164,32 @@ private void AddOrUpdateRules(ClusterState cluster)
var queueKey = new QueueKey(queueName, urlPrefix);
if (!_queuesPerDestination.TryGetValue(destination, out var queue) || !queue.Equals(queueKey))
{
if (!_queues.TryGetValue(queueKey, out var queueWeakRef) || !queueWeakRef.TryGetTarget(out queue))
var queueWeakRef = _queues.GetOrAdd(queueKey, key => new WeakReference<DelegationQueue>(new DelegationQueue(key.QueueName, key.UrlPrefix)));
if (!queueWeakRef.TryGetTarget(out queue))
{
// Either the queue hasn't been created or it has been cleaned up.
// Create a new one, and try to add it if someone else didn't beat us to it.
queue = new DelegationQueue(queueName, urlPrefix);
queueWeakRef = new WeakReference<DelegationQueue>(queue);
queueWeakRef = _queues.AddOrUpdate(
queueKey,
(key, newValue) => newValue,
(key, value, newValue) => value.TryGetTarget(out _) ? value : newValue,
queueWeakRef);
queueWeakRef.TryGetTarget(out queue);
}

if (queue is not null)
{
// We call this outside of the above if bock so that if previous
// initialization failed, we will retry it for every new destination added.
var queueState = queue.Initialize(_serverDelegationFeature);
if (!queueState.IsInitialized)
// The queue was GC'd since it was originally created
lock (queueWeakRef)
{
Log.QueueInitFailed(
_logger,
destination.DestinationId,
queueName,
urlPrefix,
queueState.InitializationException);
if (!queueWeakRef.TryGetTarget(out queue))
{
queue = new DelegationQueue(queueName, urlPrefix);
queueWeakRef.SetTarget(queue);
}
}

_queuesPerDestination.AddOrUpdate(destination, queue);
}
else

var queueState = queue.Initialize(_serverDelegationFeature);
if (!queueState.IsInitialized)
{
// This should never happen because we always create a new one above
_queuesPerDestination.Remove(destination);
Log.QueueInitFailed(
_logger,
destination.DestinationId,
queueName,
urlPrefix,
new Exception("Delegation queue is null after adding a new one. This shouldn't happen."));
_logger,
destination.DestinationId,
queueName,
urlPrefix,
queueState.InitializationException);
}

_queuesPerDestination.AddOrUpdate(destination, queue);
}
}
else
Expand Down