fixed global tool path detection #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Mac failure is unrelated to this PR, I wonder what is going on |
use macos-13 for now
filipw
commented
May 7, 2024
| @@ -259,14 +261,6 @@ public void ShouldExecuteRemoteScript(string url, string output) | |||
| Assert.Contains(output, result.Output); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ShouldExecuteRemoteScriptUsingTinyUrl() | |||
There was a problem hiding this comment.
tinyurl implemented captcha using cloudflare and we can't use it anymore 😅
however I am not sure why this test even exists, I assume to test if would follow redirects? if that is the case, then I added an http:// variant to the test above, since github returns 301 then
filipw
commented
May 7, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| run: dotnet-script build/Build.csx | |||
|
|
|||
| build-mac: | |||
| runs-on: macos-latest | |||
| runs-on: macos-13 | |||
There was a problem hiding this comment.
this forces us back into intel Macs for now
seesharper
approved these changes
May 7, 2024
IanKemp
reviewed
May 16, 2024
IanKemp
reviewed
May 16, 2024
IanKemp
reviewed
May 16, 2024
IanKemp
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697 (comment)