Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 7, 2025

Link issues

fixes #6566

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable asynchronous operation support for pop confirm buttons in table cells and clean up attribute ordering in the component

New Features:

  • Support IsAsync parameter on TableCellPopConfirmButton to enable asynchronous confirmation handling

Enhancements:

  • Reorder and align button parameter attributes in TableExtensionButton.razor for consistency

@bb-auto bb-auto bot added the bug Something isn't working label Aug 7, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 7, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR exposes and forwards the IsAsync flag to the TableCellPopConfirmButton component, enabling asynchronous confirmation behavior and reorganizing attributes for improved readability in the TableExtensionButton markup.

Class diagram for TableCellPopConfirmButton and IsAsync support

classDiagram
    class TableCellPopConfirmButton {
        +bool IsAsync
        ...
    }
    class TableExtensionButton {
        ...
    }
    TableExtensionButton --> TableCellPopConfirmButton : uses
Loading

Class diagram for TableCellButton and IsAsync usage

classDiagram
    class TableCellButton {
        +bool IsAsync
        ...
    }
    class TableExtensionButton {
        ...
    }
    TableExtensionButton --> TableCellButton : uses
Loading

File-Level Changes

Change Details Files
Support IsAsync in pop-confirm table cell buttons
  • Add pb.IsAsync attribute to PopConfirmButton tag
  • Reformat and reorder tag attributes for consistency
src/BootstrapBlazor/Components/Table/TableExtensionButton.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6566 Ensure that when the IsAsync property of TableCellPopConfirmButton is set to true, the loading animation is displayed during the execution of a long-running OnConfirm callback.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang added enhancement New feature or request and removed bug Something isn't working labels Aug 7, 2025
@bb-auto bb-auto bot added bug Something isn't working and removed enhancement New feature or request labels Aug 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Ensure that the TableCellPopConfirmButton model defines the new IsAsync property and that PopConfirmButton correctly invokes async callbacks when IsAsync is true.
  • The attribute ordering for PopConfirmButton differs from TableCellButton—consider aligning parameter order for improved readability and consistency.
  • Since both TableCellButton and PopConfirmButton share many parameters, consider refactoring common attributes into a shared component or helper to reduce duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that the TableCellPopConfirmButton model defines the new IsAsync property and that PopConfirmButton correctly invokes async callbacks when IsAsync is true.
- The attribute ordering for PopConfirmButton differs from TableCellButton—consider aligning parameter order for improved readability and consistency.
- Since both TableCellButton and PopConfirmButton share many parameters, consider refactoring common attributes into a shared component or helper to reduce duplication.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (b035658) to head (8641e3e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6569   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         719      719           
  Lines       31566    31566           
  Branches     4452     4452           
=======================================
  Hits        31560    31560           
  Misses          4        4           
  Partials        2        2           
Flag Coverage Δ
BB 99.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(TableCellPopConfirmButton): IsAsync is not working inTableCellPopConfirmButton
1 participant