feat(Toolbar): support html attribute #6573

ArgoZhang · 2025-08-08T02:56:25Z

Link issues

fixes #6572

Summary By Copilot

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary by Sourcery

Enable passing arbitrary HTML attributes to toolbar child components and simplify the Toolbar class

New Features:

Support AdditionalAttributes on ToolbarItem, ToolbarButtonGroup, ToolbarSeparator, and ToolbarSpace components

Enhancements:

Remove unused component tracking and Add/Remove methods from the Toolbar base class

sourcery-ai · 2025-08-08T02:56:31Z

Reviewer's Guide

This PR refactors the Toolbar component to remove legacy child management and uniformly adds support for arbitrary HTML attributes on toolbar child components by leveraging CssBuilder and a new ClassString property, updating both code-behind and Razor views to inherit BootstrapComponentBase and apply @attributes.

Class diagram for updated Toolbar and child components

classDiagram
    class Toolbar {
        // Removed: List<ComponentBase> _components
        // Removed: void Add(ComponentBase component)
        // Removed: void Remove(ComponentBase component)
    }
    class ToolbarItem {
        +RenderFragment? ChildContent
        -string? ClassString
    }
    class ToolbarButtonGroup {
        +RenderFragment? ChildContent
        -string? ClassString
    }
    class ToolbarSeparator {
        -string? ClassString
    }
    class ToolbarSpace {
        -string? ClassString
    }
    ToolbarItem --|> BootstrapComponentBase
    ToolbarButtonGroup --|> BootstrapComponentBase
    ToolbarSeparator --|> BootstrapComponentBase
    ToolbarSpace --|> BootstrapComponentBase

File-Level Changes

Change	Details	Files
Refactor core Toolbar class	Removed the internal _components list and associated Add/Remove methods Retained style building but simplified attribute handling via AddStyleFromAttributes	`src/BootstrapBlazor/Components/Toolbar/Toolbar.razor.cs`
Add HTML attribute support to toolbar subcomponents	Introduced ClassString property with CssBuilder.Default and AddClassFromAttributes Updated Razor views to inherit BootstrapComponentBase and apply @attributes along with the computed ClassString	`src/BootstrapBlazor/Components/Toolbar/ToolbarItem.razor` `src/BootstrapBlazor/Components/Toolbar/ToolbarItem.razor.cs` `src/BootstrapBlazor/Components/Toolbar/ToolbarButtonGroup.razor` `src/BootstrapBlazor/Components/Toolbar/ToolbarButtonGroup.razor.cs` `src/BootstrapBlazor/Components/Toolbar/ToolbarSeparator.razor` `src/BootstrapBlazor/Components/Toolbar/ToolbarSeparator.razor.cs` `src/BootstrapBlazor/Components/Toolbar/ToolbarSpace.razor` `src/BootstrapBlazor/Components/Toolbar/ToolbarSpace.razor.cs`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6572	Enable Toolbar and its subcomponents (ToolbarItem, ToolbarButtonGroup, ToolbarSeparator, ToolbarSpace) to support passing arbitrary HTML attributes via AdditionalAttributes.	✅

Possibly linked issues

feat(Toolbar): support html attribute #6572: The PR implements HTML attribute support for Toolbar components as described in the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

This reverts commit 51cb815.

codecov · 2025-08-08T03:20:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (db56431) to head (eb6dcee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          719       721    +2     
  Lines        31566     31578   +12     
  Branches      4453      4453           
=========================================
+ Hits         31566     31578   +12

Flag	Coverage Δ
BB	`100.00% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ArgoZhang added 5 commits August 8, 2025 10:47

feat: ButtonGroup 支持 html 标签

21eec93

feat: ToolbarItem 支持 html 标签

15dbf99

feat(ToolbarSeparator): 支持 html 标签

e8a7a03

feat(ToolbarSpace): 支持 html 标签

87db3a7

refactor: 删除不使用的代码

51cb815

bb-auto bot assigned ArgoZhang Aug 8, 2025

bb-auto bot added the enhancement New feature or request label Aug 8, 2025

bb-auto bot added this to the 9.9.0 milestone Aug 8, 2025

sourcery-ai bot previously approved these changes Aug 8, 2025

View reviewed changes

Revert "refactor: 删除不使用的代码"

63b84c7

This reverts commit 51cb815.

ArgoZhang dismissed sourcery-ai[bot]’s stale review via 63b84c7 August 8, 2025 03:09

fix: 更正样式名称

eb6dcee

ArgoZhang merged commit c37f5d1 into main Aug 8, 2025
6 checks passed

ArgoZhang deleted the feat-toolbar branch August 8, 2025 03:24

This was referenced Aug 15, 2025

Bump the minor group with 6 updates qin-guan/Homer#23

Closed

Bump the major group with 6 updates qin-guan/Homer#24

Closed

Bump the minor group with 6 updates qin-guan/Homer#25

Closed

This was referenced Sep 3, 2025

Bump Aspire.Hosting.AppHost and 7 others qin-guan/Homer#33

Closed

Bump the minor group with 9 updates qin-guan/Homer#34

Closed

Bump the minor group with 9 updates qin-guan/Homer#35

Closed

Bump the major group with 9 updates qin-guan/Homer#36

Closed

This was referenced Sep 9, 2025

Bump Aspire.Hosting.AppHost and 8 others qin-guan/Homer#37

Closed

Bump the minor group with 12 updates qin-guan/Homer#38

Closed

Bump the minor group with 12 updates qin-guan/Homer#39

Closed

Bump the minor group with 12 updates qin-guan/Homer#40

Closed

This was referenced Sep 16, 2025

Bump the major group with 21 updates qin-guan/Homer#41

Closed

Bump the minor group with 21 updates qin-guan/Homer#42

Closed

Bump the minor group with 21 updates qin-guan/Homer#43

Closed

Bump the minor group with 21 updates qin-guan/Homer#44

Closed

dependabot bot mentioned this pull request Sep 25, 2025

Bump the minor group with 21 updates qin-guan/Homer#45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(Toolbar): support html attribute #6573

feat(Toolbar): support html attribute #6573

Uh oh!

ArgoZhang commented Aug 8, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Aug 8, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Aug 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(Toolbar): support html attribute #6573

feat(Toolbar): support html attribute #6573

Uh oh!

Conversation

ArgoZhang commented Aug 8, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated Toolbar and child components

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

ArgoZhang commented Aug 8, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Aug 8, 2025 •

edited

Loading

codecov bot commented Aug 8, 2025 •

edited

Loading