feat(EditForm): update footer style #6579
Merged
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the EditorForm component by centralizing CSS class management via a ClassString builder, relocating the footer markup inside the cascading context, cleaning up outdated SCSS rules, and adjusts the default padding for table form-footers. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Remove the hidden BOM character before the
.bb-editorselector in EditorForm.razor.scss to prevent CSS parsing issues. - Replace the hard-coded
.form-footerpadding in Table.razor.scss with the project’s SCSS spacing variables for consistency. - Verify that moving the
@Buttonsblock inside theCascadingValuewrapper doesn’t change its cascading context or introduce side-effect styling changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove the hidden BOM character before the `.bb-editor` selector in EditorForm.razor.scss to prevent CSS parsing issues.
- Replace the hard-coded `.form-footer` padding in Table.razor.scss with the project’s SCSS spacing variables for consistency.
- Verify that moving the `@Buttons` block inside the `CascadingValue` wrapper doesn’t change its cascading context or introduce side-effect styling changes.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor/Components/EditorForm/EditorForm.razor.cs:17` </location>
<code_context>
[CascadingTypeParameter(nameof(TModel))]
public partial class EditorForm<TModel> : IShowLabel
{
+ private string? ClassString => CssBuilder.Default("bb-editor")
+ .AddClassFromAttributes(AdditionalAttributes)
+ .Build();
</code_context>
<issue_to_address>
ClassString property could be made non-nullable for clarity.
CssBuilder.Default always returns a string, so ClassString can be non-nullable to accurately represent its type.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
private string? ClassString => CssBuilder.Default("bb-editor")
.AddClassFromAttributes(AdditionalAttributes)
.Build();
=======
private string ClassString => CssBuilder.Default("bb-editor")
.AddClassFromAttributes(AdditionalAttributes)
.Build();
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6579 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 721 721
Lines 31556 31559 +3
Branches 4450 4450
=========================================
+ Hits 31556 31559 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
This was referenced Sep 3, 2025
This was referenced Sep 11, 2025
This was referenced Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6578
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update EditorForm and modal form-footer styles, refactor root class handling and fix footer margin/padding
Bug Fixes:
Enhancements: