Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 11, 2025

Link issues

fixes #6599

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump OpcDa package to v9.0.3 and refactor the sample component to simplify tag handling and value retrieval

Enhancements:

  • Simplify read and update logic by looking up items by name instead of index and removing numeric scaling and culture formatting
  • Standardize on Tag1 and Tag2 for both read and subscription workflows and update UI labels accordingly
  • Remove unused Tag3 and Tag4 constants from the sample
  • Update default OPC DA server URL to drop the mock suffix
  • Convert browse results to the new collection initializer syntax

Build:

  • Bump package version to 9.0.3

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 11, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 11, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 11, 2025

Reviewer's Guide

This PR upgrades the OpcDa sample to v9.0.3 by removing obsolete imports/constants, refactoring read and update logic to lookup by tag name, correcting subscription and browsing initializations, updating UI labels to use the primary tags, and bumping the project version.

File-Level Changes

Change Details Files
Clean up unused imports and constants
  • Removed System.Globalization import
  • Removed Tag3 and Tag4 constant definitions
  • Updated default _serverName URL to remove '/Mock' suffix
src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor.cs
Refactor Read and UpdateValues to lookup items by name
  • Replaced index-based .Read() extraction with FirstOrDefault/Find by Name
  • Added null checks before calling ToString()
  • Removed culture-specific division and formatting
src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor.cs
Correct subscription item setup
  • Changed subscription.AddItems arguments from Tag3/Tag4 to Tag1/Tag2
src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor.cs
Update tree browsing initialization
  • Replaced .Select(...).ToList() with C# range-based array initializer for roots
src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor.cs
Update Razor UI to use new tag labels
  • Replaced UI labels for Tag3 and Tag4 with Tag1 and Tag2 in the Razor template
src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor
Bump project version to 9.0.3
  • Updated BootstrapBlazor.Server.csproj to version 9.0.3
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#6599 Bump the version of the OpcDa feature to 9.0.3.
#6599 Update dependencies path in the OpcDa sample code.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/OpcDa.razor.cs:47` </location>
<code_context>

     private void OnRead()
     {
-        var values = OpcDaServer.Read(Tag1, Tag2);
</code_context>

<issue_to_address>
Consider using dictionaries and TryGetValue to simplify tag lookups and reduce code nesting.

Here’s a way to keep exactly the same behavior but reduce both LOC and nesting by:

1. Turning your read/update lists into a `Dictionary<string, object?>` (via `ToDictionary`)  
2. Looking up each tag just once with `TryGetValue`  
3. Reverting the browse method back to a simple `ToList()` instead of the range‐operator hack.

---

**OnRead →**

```csharp
private void OnRead()
{
    var values = OpcDaServer
        .Read(Tag1, Tag2)
        .ToDictionary(item => item.Name, item => item.Value);

    if (values.TryGetValue(Tag1, out var raw1) && raw1 != null)
        _tagValue1 = raw1.ToString();

    if (values.TryGetValue(Tag2, out var raw2)
        && raw2 is int i2)
    {
        _tagValue2 = (i2 / 100d).ToString(CultureInfo.InvariantCulture);
    }
}
```

**UpdateValues →**

```csharp
private void UpdateValues(List<OpcReadItem> items)
{
    var values = items.ToDictionary(item => item.Name, item => item.Value);

    if (values.TryGetValue(Tag3, out var raw3) && raw3 != null)
        _tagValue3 = raw3.ToString();

    if (values.TryGetValue(Tag4, out var raw4)
        && raw4 is int i4)
    {
        _tagValue4 = (i4 / 100d).ToString(CultureInfo.InvariantCulture);
    }

    InvokeAsync(StateHasChanged);
}
```

**OnBrowse →**

```csharp
private void OnBrowse()
{
    _roots = OpcDaServer
        .Browse("", new OpcBrowseFilters(), out _)
        .Select(e => new TreeViewItem<OpcBrowseElement>(e)
        {
            Text        = e.Name,
            HasChildren = e.HasChildren,
            Icon        = "fa-solid fa-fw fa-cubes"
        })
        .ToList();
}
```

This keeps all behavior (including your `/100d` scaling) but avoids repeated LINQ searches, null‐check pods and the confusing new range operator.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e6afb4f) to head (e245048).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31669     31669           
  Branches      4458      4458           
=========================================
  Hits         31669     31669           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 275043a into main Aug 11, 2025
7 of 8 checks passed
@ArgoZhang ArgoZhang deleted the chore-opc-da branch August 11, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(OpcDa): bump version 9.0.3
1 participant