chore(Deploy): update install font script #6611
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the Linux deployment script to automate the installation of the Chinese support font by piping confirmation into the apt installer, ensuring non-interactive execution. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `scripts/linux/deploy.sh:43` </location>
<code_context>
echo "*********************** install support font ***********************"
-sudo apt install fonts-wqy-microhei
+yes|sudo apt install fonts-wqy-microhei
echo "*********************** install DOTNET ***********************"
</code_context>
<issue_to_address>
Consider using non-interactive flags for apt install instead of piping 'yes'.
Piping 'yes' to apt may cause issues if additional prompts appear. Use the '-y' flag for a safer, non-interactive installation.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
yes|sudo apt install fonts-wqy-microhei
=======
sudo apt install -y fonts-wqy-microhei
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| echo "*********************** install support font ***********************" | ||
| sudo apt install fonts-wqy-microhei | ||
| yes|sudo apt install fonts-wqy-microhei |
There was a problem hiding this comment.
suggestion: Consider using non-interactive flags for apt install instead of piping 'yes'.
Piping 'yes' to apt may cause issues if additional prompts appear. Use the '-y' flag for a safer, non-interactive installation.
Suggested change
| yes|sudo apt install fonts-wqy-microhei | |
| sudo apt install -y fonts-wqy-microhei |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 721 739 +18
Lines 31562 31672 +110
Branches 4450 4458 +8
==========================================
+ Hits 31562 31672 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
This was referenced Sep 3, 2025
This was referenced Sep 11, 2025
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6610
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: