chore(Docker): add pupeteersharp support #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR configures the Docker environment and CI workflow to support PuppeteerSharp by installing Chrome and necessary fonts, adjusting ports, adding a build step, updating workflow triggers, and introducing the PuppeteerSharp dependency. Class diagram for PuppeteerSharp dependency additionclassDiagram
class BootstrapBlazor {
}
class PuppeteerSharp {
}
BootstrapBlazor --> PuppeteerSharp : uses
PuppeteerSharp : +Google Chrome dependency
PuppeteerSharp : +Font support
PuppeteerSharp : +Headless browser automation
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31672 31672
Branches 4458 4458
=========================================
Hits 31672 31672
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Dockerfile:10` </location>
<code_context>
+
+RUN apt-get update && apt-get install -y wget
+RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+RUN apt install -y ./google-chrome-stable_current_amd64.deb
+RUN rm ./google-chrome-stable_current_amd64.deb
+RUN apt install -y fonts-wqy-microhei
</code_context>
<issue_to_address>
Installing Chrome via a downloaded .deb may introduce dependency issues if not handled explicitly.
Add 'apt-get -f install' after installing the .deb to automatically resolve any missing dependencies.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
RUN apt install -y ./google-chrome-stable_current_amd64.deb
RUN rm ./google-chrome-stable_current_amd64.deb
=======
RUN apt install -y ./google-chrome-stable_current_amd64.deb
RUN apt-get -f install -y
RUN rm ./google-chrome-stable_current_amd64.deb
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `src/BootstrapBlazor.Server/Dockerfile:20` </location>
<code_context>
WORKDIR "src/BootstrapBlazor.Server"
FROM build AS publish
+RUN dotnet build
RUN dotnet publish -c Release -o /app
</code_context>
<issue_to_address>
Running 'dotnet build' before 'dotnet publish' may be redundant.
Consider removing the separate 'dotnet build' step to simplify the process, as 'dotnet publish' already includes a build.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
WORKDIR "src/BootstrapBlazor.Server"
FROM build AS publish
+RUN dotnet build
RUN dotnet publish -c Release -o /app
=======
WORKDIR "src/BootstrapBlazor.Server"
FROM build AS publish
RUN dotnet publish -c Release -o /app
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+10
to
+11
| RUN apt install -y ./google-chrome-stable_current_amd64.deb | ||
| RUN rm ./google-chrome-stable_current_amd64.deb |
There was a problem hiding this comment.
suggestion (bug_risk): Installing Chrome via a downloaded .deb may introduce dependency issues if not handled explicitly.
Add 'apt-get -f install' after installing the .deb to automatically resolve any missing dependencies.
Suggested change
| RUN apt install -y ./google-chrome-stable_current_amd64.deb | |
| RUN rm ./google-chrome-stable_current_amd64.deb | |
| RUN apt install -y ./google-chrome-stable_current_amd64.deb | |
| RUN apt-get -f install -y | |
| RUN rm ./google-chrome-stable_current_amd64.deb |
Comment on lines
18
to
21
| WORKDIR "src/BootstrapBlazor.Server" | ||
| FROM build AS publish | ||
| RUN dotnet build | ||
| RUN dotnet publish -c Release -o /app |
There was a problem hiding this comment.
suggestion: Running 'dotnet build' before 'dotnet publish' may be redundant.
Consider removing the separate 'dotnet build' step to simplify the process, as 'dotnet publish' already includes a build.
Suggested change
| WORKDIR "src/BootstrapBlazor.Server" | |
| FROM build AS publish | |
| RUN dotnet build | |
| RUN dotnet publish -c Release -o /app | |
| WORKDIR "src/BootstrapBlazor.Server" | |
| FROM build AS publish | |
| RUN dotnet publish -c Release -o /app |
This was referenced Aug 15, 2025
This was referenced Aug 20, 2025
This was referenced Aug 27, 2025
This was referenced Sep 3, 2025
This was referenced Sep 11, 2025
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6614
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable PuppeteerSharp support in the Docker setup by installing Google Chrome and required fonts, updating the build process, and adjusting CI triggers
Enhancements:
CI: