-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(ITcpSocketClient): update SetDataPackageAdapter documentation #6681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request refactors the sample implementation by simplifying DataPackageAdapter instantiation and callback registration, showcases the SetDataPackageAdapter extension method in documentation, and converts the UpdateReceiveLog async handler to ValueTask for consistency. Class diagram for updated DataPackageAdapter usageclassDiagram
class Adapters {
- CancellationTokenSource _connectTokenSource
- CancellationTokenSource _sendTokenSource
- CancellationTokenSource _receiveTokenSource
- DataPackageAdapter _dataAdapter
- bool _useDataAdapter
+ OnInitialized()
+ OnConnectAsync()
+ OnReceivedAsync(ReadOnlyMemory<byte> data)
+ UpdateReceiveLog(ReadOnlyMemory<byte> data)
}
class DataPackageAdapter {
+ ReceivedCallBack
+ DataPackageHandler
}
class FixLengthDataPackageHandler {
+ FixLengthDataPackageHandler(int length)
}
Adapters --> DataPackageAdapter : uses
DataPackageAdapter --> FixLengthDataPackageHandler : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6681 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31698 31698
Branches 4462 4462
=========================================
Hits 31698 31698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6680
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update ITcpSocketClient sample to simplify DataPackageAdapter setup and demonstrate using SetDataPackageAdapter extension.
Enhancements:
Documentation: