-
-
Notifications
You must be signed in to change notification settings - Fork 362
doc(BaiduOcr): add config documentation #6690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR enriches the BaiduOcr sample with configuration documentation steps and refactors its implementation by centralizing dependency injection in the code-behind, renaming the loading state variable, and applying minor code style improvements. Class diagram for refactored BaiduOcr componentclassDiagram
class BaiduOcr {
+IBaiduOcr OcrService
+IStringLocalizer<BaiduOcr> Localizer
+ToastService ToastService
-InvoiceEntity Invoice
-bool _isLoading
-string Icon
+OnClickToUploadBlock(UploadFile file)
}
BaiduOcr ..> IBaiduOcr
BaiduOcr ..> IStringLocalizer
BaiduOcr ..> ToastService
BaiduOcr ..> InvoiceEntity
UploadFile --> BaiduOcr: used in OnClickToUploadBlock
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds configuration documentation for the BaiduOcr component by updating the localization files and improving the code structure. The change primarily focuses on enhancing the user guidance for setting up the BaiduOcr service.
Key changes:
- Added step-by-step configuration documentation with appsettings.json example
- Updated localization strings in both Chinese and English versions
- Improved code structure by moving dependency injections to properties and modernizing syntax
- Enhanced the documentation display with proper code examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/BootstrapBlazor.Server/Locales/zh-CN.json | Added new localization keys for configuration steps and descriptions in Chinese |
src/BootstrapBlazor.Server/Locales/en-US.json | Added corresponding English localization strings for configuration documentation |
src/BootstrapBlazor.Server/Components/Samples/BaiduOcr.razor.cs | Moved dependency injections from inline to properties and modernized code syntax |
src/BootstrapBlazor.Server/Components/Samples/BaiduOcr.razor | Updated template to display new configuration documentation and use property-based dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6690 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31698 31698
Branches 4462 4462
=========================================
Hits 31698 31698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6689
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Provide configuration documentation in the BaiduOcr sample and refactor its component code structure, injection, and loading state handling.
Enhancements:
Documentation: