Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Ajax #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dougthor42 wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[WIP] Ajax #46

dougthor42 wants to merge 15 commits into from

Conversation

@dougthor42
Copy link
Owner

@dougthor42 dougthor42 commented Jan 21, 2019 •
edited
Loading

This converts all db calls to AJAX requests using our own API.

Fixes #45.

This is WIP while I figure some things out:

  1. Do I actually want AJAX requests for everything? They seem a bit slower during my own testing.
  2. How do I test the AJAX stuff?
  3. Do I like my API? I think I like the REST part, but I'm not a fan of the python function names linked to those routes.
  4. Do I like ?as_tree=1 for the API? Do I like that it modifies the structure of the returned JSON?

Also, TODO:

  • Rebase and clean up commit history before merging.
  • Remove debugging "console.log" statements in the JS.

@dougthor42
Add units to the return value of routes.get_data_as_json
d394c20 
+ Update test_routes.test_api_get_data_as_json
+ Update changelog
@dougthor42
Merge branch 'adjust-api-return-value' into 'master'
315cf13
@dougthor42
Move routes.format_data to utils.format_data
9bd6005
@dougthor42
Merge branch 'move-format-data' into 'master'
b249178
@dougthor42
Remove extra whitespace from conftest.py
e1cf41a
@dougthor42
Update docstring for utils.build_jstree_data to be more clear.
93bff4b
@dougthor42
Add example of ajax data request.
05f56de
@dougthor42
Add routes.get_metrics_as_json ('/api/v1/metrics' route).
7b7dc67
@dougthor42
Working example of the AJAX request.
5260544
@dougthor42
Update routes.get_metrics_as_json to optionally return jstree data wi…
a5d2186 
…th args['as_tree'] == 1
@dougthor42
Update index ajax request to pull correct tree data.
55bbd5b
@dougthor42
Mark a test in test_routes.py as XFail because of AJAX.
d49cb91
@dougthor42
Add tests for routes.get_metrics_as_json
d50c5b0
@dougthor42
Converted plot.html to use AJAX requests.
fdfdbd0
@dougthor42
Update changelog.
1fc9d63
@dougthor42 dougthor42 mentioned this pull request Jan 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dougthor42