Hi @jferreira-ca
Thanks for the PR.
I've updated the tests on the master branch so they shouldn't fail again for the same reason (flake8 related).
Please pull from master and bump your version.
Thanks

thanks @moomoohk.

I've gone over your change and I'm not sure this patch is needed.

While debugging the set function I discovered that the segments variable is set to: ['root', 1, 'k'] where you're obviously expecting it to be: ['root', '1', 'k'].

So I checked and the segments variable is created in the new function by calling the __safe_path__ function (util.py:62).

In the __safe_path__ function you'll find the path parser which also contains code to convert int-like segments to int objects. Your suggested patch ultimately undoes that action.

Instead of doing that, you could set dpath.options.CONVERT_INT_LIKE_SEGMENTS to False. This will disable the conversion code in the path parser.

Please let me know if this proposal solves your issue.

It worked. Thanks for your support on that. I think we can close this PR then.

sorry about that @moomoohk. I'm reopening it. The option works well if we are not using lists. But for our scenario we're using nested dicts and lists all together, on this case if we use that option it'll cause a TypeError.

Example:
imagine I want to change this nested dict in the first element on the list: {"list": [{"root": {"1": {"k": None}}}]}
like: dpath.util.new(a, "list/0/root/1/k", "new")

actual:
TypeError: list indices must be integers or slices, not str

expected:
{"list": [{"root": {"1": {"k": "new"}}}]}

I believe that problem can be overcome by using a custom creator function and passing it using the creator kwarg.

Please refer to this comment (the code there doesn't work in your specific case).

Hi @jferreira-ca,
I'm currently working on a major refactor to this project. Among other changes I've better documented the creator feature.
In case you'd like to have a look, here is the relevant code on the refactor branch: https://github.com/dpath-maintainers/dpath-python/blob/feature/refactor/dpath/types.py#L29

Hey @moomoohk thanks for the response. Before open this PR we actually tested passing a new creator function, but for this scenario specifically it does not work.

Could you please include some example code? (The creator that failed)

Even passing a creator the code still breaks cause segments.set function still tries to access the node using the int key.

@jferreira-ca I've pushed a small change to the branch bugfix/bad-type-check. Please try passing your creator on that branch and let me know if it works.

Honestly I don't understand how a creator could help on this case. The problem happens when a dict has ant int key on it as str (e.g "1": {}. Note it's not 1: {})

@jferreira-ca I've identified the issue. Please follow #169 for updates.

I'm closing this PR.

Regards.

thanks!!!