Thanks to visit codestin.com
Credit goes to github.com

Skip to content

KAFKA-3888 Use background thread to process consumer heartbeats #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 13 commits into from
Dec 21, 2017
Merged

KAFKA-3888 Use background thread to process consumer heartbeats #1266

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7fa4560
KAFKA-3888: use background thread for consumer heartbeats
dpkp Oct 7, 2017
21484ca
Updates from review
dpkp Oct 21, 2017
7a34cce
Whitespace fixup
dpkp Oct 21, 2017
1247a6f
Handle no group, no broker support, and/or manually-assigned partitio…
dpkp Oct 22, 2017
4209b88
Fix consumer iterator internal timeout to just check when coordinator…
dpkp Oct 22, 2017
3432a0b
coordinator.poll should not use join group with 0.8.2 brokers
dpkp Oct 22, 2017
e579490
Drop heartbeat_thread reference after close
dpkp Oct 22, 2017
ccff76d
Add simple test for consumer heartbeat thread
dpkp Oct 22, 2017
5b2a483
Handle session_timeout_ms / max_poll_interval_ms defaults differently…
dpkp Oct 22, 2017
2118555
Fixup KafkaConfigurationError
dpkp Oct 23, 2017
a9fdfb0
Fixup comments
dpkp Oct 23, 2017
e039108
fix tests
dpkp Oct 23, 2017
a709cc5
Fix lookup future is_done check
dpkp Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup comments
  • Loading branch information
@dpkp
dpkp committed Dec 21, 2017
commit a9fdfb08501b368743fc1716cd125ac64b16b1e8
8 changes: 4 additions & 4 deletions kafka/coordinator/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ def _send_join_group_request(self):
elif (0, 9) <= self.config['api_version'] < (0, 10, 1):
request = JoinGroupRequest[0](
self.group_id,
self.config['session_timeout_ms'], # or max(session, max_poll_interval_ms) ?
self.config['session_timeout_ms'],
self._generation.member_id,
self.protocol_type(),
member_metadata)
Expand Down Expand Up @@ -913,9 +913,9 @@ def _run_once(self):
self.disable()
return

# When consumer.wakeup() is implemented, we need to
# disable here to prevent propagating an exception
# to this heartbeat thread
# TODO: When consumer.wakeup() is implemented, we need to
# disable here to prevent propagating an exception to this
# heartbeat thread
self.coordinator._client.poll(timeout_ms=0)

if self.coordinator.coordinator_unknown():
Expand Down