Add baseline leader_epoch support for ListOffsets v4 / FetchRequest v10 #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a26dca to
e459e69
Compare
e459e69 to
d47055c
Compare
d47055c to
5d63ad9
Compare
…xpected timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds leader_epoch fields to
OffsetAndMetadataandOffsetAndTimestampstructs. Addscluster.leader_epoch_for_partiiton(tp)for future use. For now all apis use -1 as leader_epoch. This should be ok for 2.1 baseline, but need to implement full leader_epoch support before bumping to FetchRequest v11 (v2.3).Note that FetchRequest v10 also enables zstd compression.