Thanks to visit codestin.com
Credit goes to github.com

Skip to content

made errors more obvious #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cookingkode
Copy link

It was very difficult for me to debug various broker errors. Adding string variants instead of nos help in easier debugging

@cookingkode
Copy link
Author

cookingkode commented Jul 25, 2016

The failure in continuous-integration/travis-ci/pr is a KakfaServer Unavailable error..

@dpkp
Copy link
Owner

dpkp commented Jul 25, 2016

Can you give an example of the error logging you were having trouble with? I had thought the class name was always included. The standard error formatting is:

[Error {errorno}] {__name__}: {msg}

@cookingkode
Copy link
Author

Well it's not..

For example: I get NodeNorReadyError on every fresh boot. I guess connections are created on demand. Thus when initially requests go out for things like GroupCo-ordinator etc, then the client finds no connection https://github.com/dpkp/kafka-python/blob/master/kafka/client_async.py#L272

The error I get is something like this
2016-07-25 18:38:09,028.28.156042099:kafka.coordinator:123145306509312:ERROR:30790:Error sending GroupCoordinatorRequest_v0 to node 2 [1]

With the change it would appear as

2016-07-25 18:38:09,028.28.156042099:kafka.coordinator:123145306509312:ERROR:30790:Error sending GroupCoordinatorRequest_v0 to node 2 [NodeNotReadyError]

@dpkp
Copy link
Owner

dpkp commented Jul 26, 2016

Are you using master? That error formatting was updated in #760

@cookingkode
Copy link
Author

i was using 1.2.5 . Will migrate to the 1.2.6 when it comes. thanks!

Can you also please verify about my hypothesis about NodeNotReadyError? That it's benign and it's expected that connections are built on-demand and thus initial errors are expected..

@dpkp
Copy link
Owner

dpkp commented Jul 26, 2016

Yes, that is correct.

@dpkp dpkp closed this Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants