Fix #913: If key is null, skip deserializing #914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather keep the interface simple: deserializers are functions that receive bytes or None. I do not want to prevent users from specifying deserializers that transform None -> object, which would be the effect if we force skipping deserializer on None. |
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #913
I didn't test the JavaConsumer, but I suspect it skips null keys as it seems the most logical behavior.
I thought about adding this logic the message value processing as well, but I can't think of a scenario where you'd send a null message, versus it is realistic that you'd send a message with a null key.
Didn't have time to add tests yet.