Trevor davis/another inline toolbar positioning fix #2787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fxOne apologies, my fork was behind draft-js-plugins master. Fixed now, should be ready to go once checks pass. |
|
Also tagging @hatsu38 and @naveensrinivasan who seem to have write access. Sorry for the spam, it's hard tracking down who has recently contributed and has merge permissions. |
|
@nikgraf , would you be able to take a look at this? |
fxOne
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check out Contributing Guidelines. By following this template you help us to review your code.
https://github.com/draft-js-plugins/draft-js-plugins/blob/master/CONTRIBUTING.md
Checklist
Use-case/Problem
A previous PR of mine added support for max-height parents by accounting for scrollTops on ancestor nodes of the draft editor root. However, we short-circuited erroneously when that scrollTop was 0. Instead, we should keep recursing up the DOM tree.
Briefly describe the use-case/problem you're solving, reference the issue for this bug/feature here
Implementation
Briefly describe your solution
Demo
If you're implementing or changing a feature, please add a gif to demo the change, thanks!