-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Add eviction based on rss memory usage #5791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+135
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix tests |
mkaruza
previously approved these changes
Sep 11, 2025
romange
reviewed
Sep 15, 2025
romange
reviewed
Sep 15, 2025
d50b166
to
467b669
Compare
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
* Removed de-fragmentation changes * Added python test that shows eviction when rss threshold is reached * Added `enable_heartbeat_rss_eviction` flag that enabled evicition based on rss and added python test.
Signed-off-by: Stepan Bagritsevich <[email protected]>
467b669
to
c6fa4a8
Compare
Disable RSS evicition for unit tests.
ca3eec7
to
9ed3369
Compare
from it from calculation
@mkaruza can we merge this PR? |
Yes, please approve it |
romange
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr includes two other PRs, my #4991 and @mkaruza #5775