update(deps): bump to libs 0.21#2164
Merged
therealbobo merged 17 commits intodraios:devfrom Nov 27, 2025
Merged
Conversation
b54482f to
a1dcd90
Compare
416bf65 to
f6874e4
Compare
c16319d to
0da7c2f
Compare
dbef5b7 to
490cdf2
Compare
irozzo-1A
reviewed
Nov 13, 2025
Contributor
irozzo-1A
left a comment
There was a problem hiding this comment.
Thanks @therealbobo, this is great! and should address #2165 as well without having to cherry-pick fixes in the 0.20. libs branch.
Apart from a few nits, I think there are a few things we should address though.
- I got a segfault when trying it this way, to be further investigated, but I think this may be related to: falcosecurity/plugins#1019
$ sudo build/userspace/sysdig/sysdig --modern-bpf -p"%container.name" container.name!=host
dir: /usr/local/share/sysdig/plugins/
Segmentation fault
- IMO we should better handle the case in which the container plugin is not present in the fs, it's true that this should not happen when installing sysdig through package manager, but I think loosing the ability of using it standalone could be a limitation, especially for dev experience. I left a dedicated comment for this.
- falcosecurity/plugins#1046 we fixed a memleak with CRI container runtime we should probably cherry-pick to the container plugin version that works with libs
0.21, not a blocking point maybe as this should be less critical for a tool as sysdig, but we should consider it IMO
Contributor
|
@therealbobo Unfortunately the latest plugin version I'm checking if we could cherry-pick falcosecurity/plugins#1019 and falcosecurity/plugins#1046 and create a 0.3.2 plugin release. |
Contributor
This should make it, instead of cherry-picking the required changes to a previous version, we could make sure the container plugin is still compatible with libs |
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
3a92386 to
142be17
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.