Add missing unsigned property to decimal datatypes#883
Open
Jadu07 wants to merge 2 commits intodrawdb-io:mainfrom
Open
Add missing unsigned property to decimal datatypes#883Jadu07 wants to merge 2 commits intodrawdb-io:mainfrom
Jadu07 wants to merge 2 commits intodrawdb-io:mainfrom
Conversation
|
@Jadu07 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@1ilit pls review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #878
This pull request fixes an issue where the UNSIGNED option was only available for integer types, even though MySQL and MariaDB also support it for DECIMAL, NUMERIC, FLOAT, and DOUBLE, which caused schemas using unsigned decimal-based fields to be exported incorrectly, the update makes UNSIGNED available for all supported numeric types in both the builder UI and the generated SQL, ensuring correct and expected schema exports.
To resolve this, the signed: true property has been added to the DECIMAL, NUMERIC, FLOAT, and DOUBLE type definitions under mysqlTypesBase in src/data/datatypes.js, allowing the Unsigned toggle to appear correctly in the field configuration UI and ensuring the UNSIGNED keyword is properly included in SQL generated by the export utilities.