feat(runner): expose Documents folder in the Files app - #12
Merged
Merged
Conversation
Declare UIFileSharingEnabled and LSSupportsOpeningDocumentsInPlace (plus CFBundleDisplayName "Mobilerun") in WebDriverAgentRunner/Info.plist so files written into the WDA container's Documents/ can be browsed on-device and pulled via AFC house-arrest (go-ios/ifuse). Xcode's XCTRunner template does not inherit custom Info.plist keys from the test bundle, so a new scheme post-action (Scripts/enable-runner-file-sharing.sh) lifts them out of PlugIns/<product>.xctest into Runner.app/Info.plist and re-signs, following the same pattern as the icon and broadcast-extension embeds. Wired into the WebDriverAgentRunner and WebDriverAgentRunner-nodebug schemes; tvOS is untouched (no Files app). Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files written into the WDA runner's container
Documents/are now visible on-device in the Files app (under "On My iPhone > Mobilerun") and accessible over AFC house-arrest document sharing (go-ios/ifuse).UIFileSharingEnabled,LSSupportsOpeningDocumentsInPlace, andCFBundleDisplayName("Mobilerun") inWebDriverAgentRunner/Info.plistas the source of truth.PlugIns/<product>.xctestwhere iOS never looks. A new scheme Build post-action (Scripts/enable-runner-file-sharing.sh) lifts the keys intoRunner.app/Info.plistand re-signs, following the same pattern as the existing icon and broadcast-extension embed scripts.WebDriverAgentRunnerandWebDriverAgentRunner-nodebugschemes; tvOS untouched (no Files app).Note: only files under the container's
Documents/subdirectory show up in the Files app; re-signing pipelines must preserve the patchedRunner.app/Info.plist.Test plan
build-for-testingvia theWebDriverAgentRunnerscheme logsenabled Files app sharing in …Runner.appWebDriverAgentRunner-Runner.app/Info.plistcontains both keys (true) andCFBundleDisplayName= Mobileruncodesign --verify --deep --strictpasses on the patched appDocuments/🤖 Generated with Claude Code