Resizing an element from very large to very small was not possible #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le because the resulting size deviated from the mouse position, especially in case of small grid dimensions
|
@alexnb i know it has been a long time but, could you discard changes done to the release information? release information should only be updated by upstream. Thanks for your support. |
alexnb
added a commit
to alexnb/gridster.js
that referenced
this pull request
Jul 20, 2018
This reverts commit 1c84797. (as asked by @fixmycode for PR dsmorse#112)
alexnb
added a commit
to alexnb/gridster.js
that referenced
this pull request
Jul 20, 2018
This reverts commit 8639a29. (as asked by @fixmycode for PR dsmorse#112)
|
Was resubmitted as #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting size deviated from the mouse position, especially in case of small grid dimensions. Reason: the margin was taken twice instead of once (gridster margin is semantically different to css margin, it equals 1/2 of the margin value at left/right/top/bottom!)