Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove trailing comma for pointer_events #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bfarka opened this issue Nov 21, 2014 · 0 comments
Open

Remove trailing comma for pointer_events #469

bfarka opened this issue Nov 21, 2014 · 0 comments

Comments

@bfarka
Copy link

bfarka commented Nov 21, 2014

Our static code analysis tool detected a trailing comma for the pointer_events

BAD:

    fn.events = function() {
        this.pointer_events = {
            start: this.nsEvent('touchstart') + ' ' + this.nsEvent('mousedown'),
            move: this.nsEvent('touchmove') + ' ' + this.nsEvent('mousemove'),
            end: this.nsEvent('touchend') + ' ' + this.nsEvent('mouseup'),
        };

GOOD:

    fn.events = function() {
        this.pointer_events = {
            start: this.nsEvent('touchstart') + ' ' + this.nsEvent('mousedown'),
            move: this.nsEvent('touchmove') + ' ' + this.nsEvent('mousemove'),
            end: this.nsEvent('touchend') + ' ' + this.nsEvent('mouseup')
        };

image
bfarka pushed a commit to bfarka/gridster.js that referenced this issue Nov 21, 2014
fix issue ducksboard#469
d09dea2 
remove trailing comma to be more IE compliant
@bfarka bfarka mentioned this issue Nov 21, 2014
Open
dsmorse pushed a commit to dsmorse/gridster.js that referenced this issue Apr 8, 2015
Merge remote-tracking branch 'bfarka/gridster.js/fix-trailing-comma'
e7509f0 
* bfarka/gridster.js/fix-trailing-comma:
  fix issue ducksboard#469
ciprianmiclaus pushed a commit to ciprianmiclaus/gridster.js that referenced this issue Feb 28, 2016
@ciprianmiclaus2
Merge pull request #3 from bfarka/fix-trailing-comma
5cd9a6a 
fix issue ducksboard#469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfarka