Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 24, 2025. It is now read-only.

Conversation

@m3ller
Copy link
Contributor

@m3ller m3ller commented Apr 17, 2019

  • For this fix, do I need to do a minor version bump on dwavebinarycsp? (I'm guessing yes, but please confirm)
  • Actually, requirements.txt is already correct and I'm only changing setup.py. Does this still require a minor version bump?

Melody Wong added 2 commits April 16, 2019 18:05
Lowerbound in all other penaltymodels in this setup.py support a Specification object with min_classical_gap as an attribute. Cache should do the same.
@codecov-io
Copy link

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          18       18           
  Lines         615      615           
=======================================
  Hits          568      568           
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cee27...1c5a580. Read the comment docs.

@arcondello arcondello self-requested a review April 18, 2019 00:19
@arcondello arcondello merged commit d6b1e70 into dwavesystems:master Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants