Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

fix(logs): add/remove misplaced spaces#1231

Merged
azlam-abdulsalam merged 3 commits into
dxatscale:mainfrom
alanjaouen:fix/spacing
Feb 15, 2023
Merged

fix(logs): add/remove misplaced spaces#1231
azlam-abdulsalam merged 3 commits into
dxatscale:mainfrom
alanjaouen:fix/spacing

Conversation

@alanjaouen

@alanjaouen alanjaouen commented Feb 15, 2023 •
edited by azlam-abdulsalam
Loading

Copy link
Copy Markdown
Contributor

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@codecov-commenter

codecov-commenter commented Feb 15, 2023

Copy link
Copy Markdown

Codecov Report

Base: 59.80% // Head: 59.80% // No change to project coverage 👍

Coverage data is based on head (5211db3) compared to base (0fc73dc).
Patch has no changes to coverable lines.

❗ Current head 5211db3 differs from pull request most recent head 1c21b00. Consider uploading reports for the commit 1c21b00 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   59.80%   59.80%           
=======================================
  Files          63       63           
  Lines        2090     2090           
  Branches      449      449           
=======================================
  Hits         1250     1250           
  Misses        788      788           
  Partials       52       52
Impacted Files Coverage Δ
...re/src/permsets/PermissionSetGroupUpdateAwaiter.ts 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azlam-abdulsalam azlam-abdulsalam self-requested a review February 15, 2023 05:41
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Feb 15, 2023
@azlam-abdulsalam

azlam-abdulsalam commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @alanjaouen keep it coming!

azlam-abdulsalam
azlam-abdulsalam approved these changes Feb 15, 2023
View reviewed changes

@azlam-abdulsalam azlam-abdulsalam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

@azlam-abdulsalam azlam-abdulsalam merged commit 2d09f6e into dxatscale:main Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@azlam-abdulsalam azlam-abdulsalam azlam-abdulsalam approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

Release - February 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@alanjaouen @codecov-commenter @azlam-abdulsalam