This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix(pools): move recovery functionality to delete#1237
Merged
Conversation
* feat(pool): recover orphaned scratch orgs Scratch orgs when created during prepare can be timed out at the client side (aka at the execution of prepare), however these scratch orgs might get created in the backend and consume an active limit, but is not recovered by sfpowerscripts upon delete. Users have to manually delete thes orgs out or wait till these orgs are expired, so that the active limits are back. This functionality uses description filed to determine which scratch orgs were requested by sfpowerscripts and then proceed to delete during an execution of prepare command before and after the pools are created * [CodeFactor] Apply fixes * Apply suggestions from code review --------- Co-authored-by: codefactor-io <[email protected]>
recovery of oprhaned scratch orgs are moved to the delete command, with an addition of '-o' flag. This will alllow the user to run dur
zhebinliu
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(pools): move recovery functionality to delete
recovery of oprhaned scratch orgs are moved to the delete command, with an addition of '-o' flag. This will alllow the user to run dur
ing the normal cleanup or out of bound and removes the race conditions which had caused it to be reverted earlier
Checklist
All items have to be completed before a PR is merged