Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

feat(validate): display info about the org that is used for validation#1239

Merged
azlam-abdulsalam merged 4 commits into
mainfrom
feat/pool-verbose
Feb 17, 2023
Merged

feat(validate): display info about the org that is used for validation#1239
azlam-abdulsalam merged 4 commits into
mainfrom
feat/pool-verbose

Conversation

@azlam-abdulsalam

@azlam-abdulsalam azlam-abdulsalam commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

In some cases, devs would like to understand what went wrong in a validation run. sfpowerscripts
currently do not provide an easy mechanism which displays those details. So in those instances
additional scripts need to be done that will display the org info by traversing the org list. This
enhancement will display the org info when an additional flag is passed to validate.

Please note this flag has to be used without using the --deletescratchorg flag, otherwise the displayed info would not be good for consumption as the org would have been already deleted.

New flag to validate command --orginfo

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

In some cases devs would like to understand what went wrong in a validation run. sfpowerscripts
currently do not provide an easy mechanism which displays those details. So in those instances
additional scripts need to be done that will display the org info by traversing the org list. This
enhancement will display the org info when an additional flag is passed to validate.
@codecov-commenter

codecov-commenter commented Feb 17, 2023

Copy link
Copy Markdown

Codecov Report

Base: 60.48% // Head: 60.48% // No change to project coverage 👍

Coverage data is based on head (366df01) compared to base (0739751).
Patch has no changes to coverable lines.

❗ Current head 366df01 differs from pull request most recent head 44522cf. Consider uploading reports for the commit 44522cf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   60.48%   60.48%           
=======================================
  Files          64       64           
  Lines        2126     2126           
  Branches      453      453           
=======================================
  Hits         1286     1286           
  Misses        788      788           
  Partials       52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Cherie-she

Copy link
Copy Markdown

Wonderful Idea! will definitely make the sfpowerscript even more powerful!

Comment thread packages/sfpowerscripts-cli/src/impl/validate/ValidateImpl.ts Outdated
@azlam-abdulsalam azlam-abdulsalam merged commit c7a4895 into main Feb 17, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the feat/pool-verbose branch February 17, 2023 04:54
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement enhancement to existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants