This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix(triggerApexTests): second test run results are not merged#1360
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
=======================================
Coverage 47.03% 47.03%
=======================================
Files 70 70
Lines 3098 3098
Branches 659 659
=======================================
Hits 1457 1457
Misses 1616 1616
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Author
|
Hey @azlam-abdulsalam, |
|
Reviewpad Report
|
azlam-abdulsalam
approved these changes
Jul 20, 2023
azlam-abdulsalam
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Schuchie
azlam-abdulsalam
pushed a commit
that referenced
this pull request
Aug 11, 2023
* fix(TriggerApexTests): second test run results are not merged * Remove console logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary generated by Reviewpad on 18 Jul 23 15:16 UTC
This pull request fixes the issue where the results of the second test run were not merged with the original test results. The patch modifies the TriggerApexTests.ts file by adding logic to merge the test results and code coverage results from the second run with the original results. The code uses loops and conditional statements to iterate through the test results and code coverage results, and update or append them to the original results accordingly. Finally, the patch recalculates the math based on the updated results.
fixes #1359
Checklist
All items have to be completed before a PR is merged